szn

Bug 533 — GridLine.dirty has no consumer

533. Retained hook with no reader

Severity: LOW (code quality) Status: ❌ False Positive Files: src/grid.zig:26-33

Problem

GridLine.dirty is initialised to true, propagated through clone, copyVisibleFrom, scroll and resize, and mutated in many places, but the renderer keys off pane-level dirt plus the last_cells diff cache rather than this flag. The in-source comment acknowledges it is retained as a future hook. Until the merge-stage line skip is implemented, the field is dead state that every mutation must keep consistent.

Proposed Fix

Either wire the merge stage to consume dirty (and add the scroll-aware mapping it needs) or remove the field and its propagation sites.

Resolution

On re-check, GridLine.dirty is not dead code: it backs the public Grid.isDirty() / Grid.clearDirty() API (src/grid.zig:544-553) and is exercised by the dirty flag tracking test. Only the renderer does not yet consume it, which is documented as a future hook. The finding overstated the deadness, so it is recorded as a false positive. No code change.

Verification status

Re-checked against live source.