Severity: LOW (latent heap corruption via API misuse)
Status: 🟢 FIXED
Files: src/input.zig:91-94
pub fn deinit(self: *InputParser, allocator: std.mem.Allocator) void {
self.dcs_buf.deinit(allocator);
self.osc_buf.deinit(allocator);
}
All 13 allocation sites for these buffers use self.screen.allocator, but deinit accepts an arbitrary allocator parameter. Passing anything else (easy to do — the signature suggests the caller chooses) frees the buffers into the wrong allocator → heap corruption or crash. Tests happen to pass testing.allocator consistently, which masks the footgun.
Drop the parameter and free with self.screen.allocator internally — the parser already owns a reference to the allocating context, so the parameter serves no purpose except to invite misuse.
src/input.zig, updated InputParser.deinit(self: *InputParser) void to deinitialize dcs_buf and osc_buf using self.screen.allocator without accepting an external allocator parameter.src/window.zig (Pane.deinit) to invoke p.deinit().src/input.zig to call parser.deinit().src/input.zig verifying InputParser.deinit() successfully frees buffers without an external allocator parameter.allocator-parameter pattern in layout.zig/window.zig/session.zig (accepted then ignored) is the same class of misleading signature.