Severity: LOW (code quality)
Status: ✅ FIXED
Files: src/cmd/cmd.zig, src/server/render.zig, src/screen.zig, src/format.zig, src/status.zig, src/grid.zig
cmd/cmd.zig:813-863 cmdHelp vs :1711-1761 formatHelp: identical Name/Alias/Usage blocks and list loops.render.zig:277-322 top-border vs left-border border_format branches dup decode + fg-select; :199-211 vs :471-484 history/combined_idx geometry dup.screen.zig:441,462,474 three 64-slot id searches differing by one line; :612-629 vs :631-648 scroll-region up/down mirrors; :1018-1055/:1057-1099 erase arms triplicated.format.zig:544-571,616-643,645-672 conditional/compare/and-or share one splitArgs+expandTemp+truthy skeleton x3.status.zig:109-128 visibleLen vs :154-181 truncateVisible dup ESC-skip/decode/width logic.render.zig:369-417 ~= server.zig:2183-2202 ~= layout.zig split handling.grid.zig:165-194 vs :337-404 history-ring compaction shares ring-index arithmetic.cfg.zig:277 trimLeft duplicates std.mem.trimLeft; cmd.zig:689-690 one-line indexOfIgnoreCase wrapper used once.grid.zig:533-544 isDirty/clearDirty + all GridLine.dirty writes: no production reader (render uses pane.dirty + last_cells); pure write overhead.clock.zig:67 _ = sx ignores width; choose.zig:111 unused Allocator param; char_width.zig:796-797 tautological test; screen.zig:502-513 _ = x suppressed index.catch {}: cmd.zig:36,40,44,1963 killSession catch {} hides failures (remainder of the old 91-instance sweep already fixed per bug #339).Extract shared helpers (help formatter, border-cell emitter, history-geometry resolver, sixel-slot finder, scroll-region swapper, format-branch evaluator, visible-width scanner, split-geometry function); delete or wire up GridLine.dirty (either consult it in render or remove the flag); remove dead params/wrappers or mark deliberately-kept ones with a comment.
cmdHelp vs formatHelp (src/cmd/cmd.zig): extracted shared
appendEntrySummary / appendEntryDetail emitters; both paths now call
the same code so the outputs cannot drift.src/screen.zig): isImageReferenced and
findSixelImage are now one-line wrappers over the single
findSixelImageSlot scan.src/server/render.zig): extracted shared
resolveRowCells used by both the merge stage and the single-pane
content path.src/server/render.zig): extracted shared
paintBorderCell (cross-merge rule + fg paint).src/status.zig): extracted shared measureChunk
used by both visibleLen and truncateVisible.layout.splitSizes (fixed under bugs
#467/#468, which also resolves this cluster’s triplication item).cfg.trimLeft: replaced with stdlib (fixed under bug #476).clock.renderClock no longer takes the ignored sx;
ChooseMode.handleKey no longer takes the unused allocator (9 call sites
updated); cmdFindWindow calls std.ascii.indexOfIgnoreCase directly
(one-line wrapper deleted).scrollUpInRegion / scrollDownInRegion mirrors: every line differs
(loop direction, blank target, anchor delta, cursor guard) and these paths
have a history of region bugs (#368/#369/#419) — explicit beats clever.splitArgs, expandTemp, freeArgs)
already are the factored layer.GridLine.dirty: retained with a doc comment — it carries tested copy
semantics through scroll/clone/compact, and a merge-stage skip needs
scroll-aware mapping to be correct (future work, not removable safely).Full suite (zig build test) passes.