szn

Bug 467 — Unvalidated layout proportion reaches @intFromFloat and can panic

467. proportion:f64 flows unchecked into float-to-int

Severity: HIGH Status: ✅ FIXED Files: src/layout.zig, src/server/render.zig, src/server/server.zig


Root Cause Analysis

layout.zig:104,110,238,245:

@as(u32, @intFromFloat(@as(f64, @floatFromInt(available)) * proportion))

splitPane is public; only cmd/cmd.zig:185 validates (0,1). findNodeBounds, render.zig:371,395, server.zig:2191, window.zig:399 recompute without checks. Negative/NaN/Inf → @intFromFloat to u32 panics/UB.

Proposed Fix

Centralize: validate 0.0 < proportion < 1.0 + std.math.isFinite at splitPane and clamp/defend in every findNodeBounds-style recompute. Add tests for NaN/Inf/2.0/-0.5.