szn

Bug 457 — Dead errdefer in set-buffer path leaks generated name on OOM

457. errdefer in a non-error-returning function never runs

Severity: MEDIUM Status: ✅ FIXED Files: src/cmd/cmd.zig, src/buffer.zig


Root Cause Analysis

In src/cmd/cmd.zig:604-610:

const name = server.buffers.generateName() catch return .err;
errdefer server.allocator.free(name); // dead: fn returns CmdResult
const owned_data = data.toOwnedSlice(server.allocator) catch return .err; // leaks name
server.buffers.pushOwned(name, owned_data) catch {
    server.allocator.free(owned_data); // leaks name (see bug 456)
    return .err;
};

Same dead-errdefer shape at cmdDisplayMessage:662.

Proposed Fix

Replace errdefer with explicit free(name) on each error return, and free both slices when pushOwned fails. Same repair at cmdDisplayMessage.