szn

Bug 456 — BufferList.pushOwned leaks name and data on insert OOM

456. Owned-slice insert without errdefer

Severity: MEDIUM Status: ✅ FIXED Files: src/buffer.zig


Root Cause Analysis

In src/buffer.zig:39-42:

pub fn pushOwned(self: *BufferList, name: []const u8, data: []const u8) !void {
    self.evictOldestIfFull();
    try self.items.insert(self.allocator, 0, .{ .name = name, .data = data });
}

insert can fail OOM after eviction; neither slice is freed. Contrast push:44-50 which has errdefer free(n)/free(d).

Proposed Fix

errdefer { self.allocator.free(name); self.allocator.free(data); }
try self.items.insert(...);

Add failing-allocator test for pushOwned.