Severity: MEDIUM Status: Fixed
cmdNewSession adds the session to server.sessions (inside newSession) and then sets up its pane. A later failure leaves the session attached:
// src/cmd/cmd.zig:32-45
fn cmdNewSession(server: *Server, args: []const []const u8) CmdResult {
const name = if (args.len > 1) args[1] else "default";
const session = server.newSession(name, 80, 24) catch return .err; // attaches to server.sessions
const pane = (session.active_window orelse return .err).active_pane orelse return .err;
server.setupPane(session, pane, null) catch return .err; // may fail AFTER attach
if (server.sessions.items.len > 1) {
// rotate to front
}
return .ok;
}
setupPane fails (e.g. PTY spawn error, tty setup error), cmdNewSession returns .err but the session created by newSession is already in server.sessions.kill-session.join-pane/split-pane rollback logic (bug #287) was added to protect.Either create the session detached and only insert it into server.sessions after setupPane succeeds, or add an errdefer server.killSession(name) (or equivalent scoped cleanup) that removes the session if any later step fails.