szn

Bug 428 — Use-after-free of MessageReader in handleClient packet loop

428. Use-after-free of MessageReader in handleClient packet loop

Severity: HIGH Status: Fixed

handleClient() grabs a raw pointer to the client’s MessageReader from the hash map, then loops over parsed packets. Inside the loop, any handler (e.g. .detach) may call removeClient(fd), which allocator.destroys the reader. After the loop exits, the defer reader.consume(pkt) still dereferences the freed pointer.

// src/server/server.zig:2434
const reader = self.client_readers.get(fd) orelse return;
try reader.feed(buf[0..n]);

while (try reader.tryParse()) |pkt| {
    defer reader.consume(pkt);          // runs AFTER the loop on a freed reader
    // ... handler dispatch ...
    .detach => {
        self.removeClient(fd);           // :2554 — frees the reader
    },
}

// src/server/server.zig:2589 (inside removeClient)
if (self.client_readers.fetchRemove(fd)) |entry| {
    self.allocator.destroy(entry.value); // frees the MessageReader
}

Problem & Impact

Proposed Fix

Do not hold a raw reader pointer across handler dispatch. Either: