szn

Bug 424 — Dead code inventory round 2

424. Dead code inventory round 2: stale Term/FdWriter modules, never-entered parser states, write-only fields, message_reader serializer suite, server.zig.orig backup

Severity: LOW Status: ✅ RESOLVED

Verified unreferenced in production (grep across src/) after the #392 round:

Site Finding
server.zig:587 tickEscapeTime never called; run() inlines a divergent variant (:602-612) — two implementations of one rule.
loop.zig Loop.stop, hasFd no production callers (tests only).
tty.zig:27-477 entire Term struct; fd_writer.zig FdWriter zero production callers; render.zig imports the module solely for its Error alias.
render.zig:96-103 Display.writeString/writeStr; renderAll params session_name/windows/active_window no callers / _ = discarded.
grid.zig insertLine, deleteLine, scrollDown (prod uses shiftDown), clearArea, reflow, getHistoryLineMut no production callers.
screen.zig setCursorAbs, hasSixelImages; window.zig:80 Pane.writeStr test-only; writeStr also iterates bytes as codepoints.
input.zig:74 InputParser.reset; State.csi_final/dcs_final dispatch arms exist (:172,:180) but no transition ever assigns them → advanceCsiFinal/advanceDcsFinal unreachable.
protocol.zig isRequest; message_reader.zig serializePacket, make*Packet (6), packetType, reset own tests only — clients use Packet.deserialize/make directly.
server.zig:133-134 next_window_id/next_pane_id; :161 pane_border_fmt_cache; :171 status_click_width; screen.zig:23 SixelImage.col; :97 mode.mouse_utf8; input.zig:796-798 screen.extkeys declared/write-only, never read (extkeys: modifyOtherKeys state has no consumer in this tree).
tty_key.zig:15 Event.resize never constructed by InputReader.
char_width.zig:147-148 isCombining early-returns unreachable (ranges not in zero_width_ranges); log.zig:120-135 lazy-open unreachable (log_enabled only set by openers).
key.zig:96-104 top-level mod computation for 'u' finals is dead (branch recomputes).
src/server/server.zig.orig 3,549-line stale backup (current is 5,353); nothing references it — delete.
window.zig Window.deinit unreachable in production (kill paths go through Session.killWindow), so its last_foreground_name free is dead — see also #358/#405.
Window.addPane/splitPane, Layout.splitPane allocator params accepted then _ = allocator; — silently use self.allocator (flagged by the bug-#91 test comment; remove the param).

Fix: delete or wire up each row; keep one implementation of the escape-time rule.