Severity: LOW Status: ✅ FIXED
CopyMode.getCellAt (unused wrapper) — deleted.CopyMode.search_active write-only field and its three writes — deleted;
the server’s search_pending remains the single source of truth.adjustSelectionForAutoScroll(delta) ignored its parameter — signature
simplified to no-arg with a doc comment; both server call sites updated.CmdArgs.exec’s inline for dispatch looks like a no-op but implements the
comptime-table mandate from bug #335; replacing it with a direct call would
regress that decision. Documented here instead.identify_term payload stays for wire compatibility (removing the message
type would renumber the protocol enum); noted as reserved surface.| # | Site | Finding |
|---|---|---|
| a | mode_copy.zig:258-260 | CopyMode.getCellAt defined, never called (callers use getCellAtOffset directly). |
| b | mode_copy.zig:46 | search_active write-only (set at :67/:74/:82, never read) — server tracks prompt state in Server.search_pending. Misleading duplicate state. |
| c | mode_copy.zig:217-220 | adjustSelectionForAutoScroll(self, delta) ignores delta; works today only because start_scroll_offset remapping compensates. Signature promises something it doesn’t do. |
| d | cmd.zig:1642-1649 | CmdArgs.exec’s inline for (CMD_TABLE) comparing entry == self.entry falls through to exactly the same call a direct dispatch makes. Replace with return self.entry.exec(server, self.args); (note #335 history). |
| e | protocol.zig:14 + server.zig:2283-2320 | identify_term payload documented but never read; registration identical for empty payloads. Dead protocol surface. |
| f | server.zig:1003-1036 | Detach deinits/swapRemoves the DisplayClient but leaves the fd polled/in client_fds until the peer closes (reattach support). Consistent with .detach message handling; document the asymmetry explicitly. |