Severity: LOW (cluster) Status: ✅ FIXED
| # | Site | Finding |
|---|---|---|
| a | cmd.zig:441-453 | break-pane: after extractPane + insertion into the new window, a failing resizeTerminal returns .err while the pane is fully relocated — caller-visible state contradicts result. The panes.items.len > 0 guard can silently orphan the extracted pane if the invariant ever breaks. Assert instead of guard. |
| b | cmd.zig:153 | split-window -p <garbage> silently coerces to 0.5 via parseFloat catch 0.5; values like 5 or -1 pass unvalidated into splitPane. Validate range (0,1) and error on parse failure. |
| c | cmd.zig:236-243 | move-window: ensureTotalCapacity(len) doesn’t cover the subsequent insert (needs len+1); on double allocation failure the window is removed and never re-added (live ptys drop off ownership graph). Reserve len+1 and restore-on-failure. |
| d | cmd.zig:1053-1058 | resize-pane -L 99999 -x 100: relative-adjustment validation errors out before explicit -x/-y sizes are honoured. Apply exact sizes first, then clamp relatives. |
| e | cmd.zig:509-510 | save-buffer: if (n < 0) break; without EINTR retry — a signal mid-write turns success into .err. |
| f | cmd.zig:1092 vs server.zig:3092 | Same unknown-command binding: config loader silently drops (orelse continue), interactive bind-key errors (return .err). Divergent feedback for identical input. |