szn

Bug 362 — UAF window: stale poll events after session teardown in one batch

362. The guard itself dereferences freed memory

File: src/server/server.zig:707-717 Severity: HIGH Status: ✅ FIXED

Problem

One pollOnce batch may contain multiple pty events. If an earlier event’s dispatch runs a command that kills the session (session.deinit → arena.deinit()), later events in the same batch still hold udata pointing into the freed arena:

var pane: *Pane = @ptrCast(@alignCast(ev.udata orelse return .not_ours));
if (!self.isPaneValid(pane)) {      // ← reads pane.valid from freed memory

Root Cause

isPaneValid previously performed return pane.valid; directly, which accessed the pointer even if the enclosing session arena had already been deallocated.

Fix (applied)