catch {} silent error suppression violates Zig 0.16 rule #6catch {} silent error suppression (91 instances)Files: src/server/server.zig, src/cmd/cmd.zig, src/main.zig, src/window.zig, src/server/dispatch.zig, src/server/render.zig, src/input.zig, src/layout.zig, src/socket_path.zig
Severity: HIGH
Status: ✅ FIXED
All 91 instances of catch {} replaced with proper error logging:
// Before:
pane.feedPty() catch {}
// After:
pane.feedPty() catch |err| std.log.warn("feedPty failed: {any}", .{err})
Breakdown by file:
| File | Instances fixed |
|---|---|
src/server/server.zig |
77 |
src/cmd/cmd.zig |
4 |
src/main.zig |
2 |
src/window.zig |
3 |
src/server/dispatch.zig |
1 |
src/server/render.zig |
1 |
src/input.zig |
1 |
src/layout.zig |
1 |
src/socket_path.zig |
1 |
| Total | 91 |
Pattern used: Each catch {} was replaced with catch |err| std.log.warn("...failed: {any}", .{err}). The _ = prefix was preserved where present. For errdefer contexts, the catch |err| was added directly.
Verification: grep -r 'catch {}' src/ --include='*.zig' returns zero matches. All 870 tests pass.