renderToDisplayClient frees string literals via pane_border_ownedrenderToDisplayClient frees string literals via pane_border_ownedFile: src/server/server.zig:2380–2419
Severity: HIGH
Status: ✅ FIXED — the empty-format path and the expand-failure fallback now set pb.border_format = "" without enqueueing a literal; only successfully allocated slices enter pane_border_owned. Regression test renders with pane-border-format "".
defer {
for (pane_border_owned.items) |f| self.allocator.free(f); // frees EVERY entry
pane_border_owned.deinit(self.allocator);
}
...
if (pane_border_fmt_str.len == 0) {
pane_border_owned.append(self.allocator, "") catch {}; // literal "" enqueued
continue;
}
const expanded = format_mod.expand(...) catch |err| blk: {
break :blk ""; // literal "" enqueued
};
pane_border_owned.append(self.allocator, expanded) catch {};
Two paths append a static string literal ("") to pane_border_owned: (1) when pane-border-format is set to empty, and (2) when format_mod.expand fails. The defer then calls allocator.free("") on the literal — invalid free / allocator corruption.
Trigger: set -g pane-border-format "", or any format-expansion error (OOM/malformed template).