szn

Bug 228 — Packet.deserialize and Packet.serialize buffer panic hazards

228. Packet.deserialize and Packet.serialize buffer panic hazards

File: src/server/protocol.zig:71, 83–92 Severity: CRITICAL Status: ✅ FIXED

  1. Packet.deserialize reads len from header and checks if (buf.len < len). If a malformed packet specifies len < 5 (e.g. len = 3), buf[5..len] triggers a Zig slice bounds panic (start > end).
  2. Packet.serialize executes @memcpy(buf[5..], self.data) without validating buf.len >= 5 + self.data.len.

Impact: Server crash/panic upon receiving malformed IPC packets or writing to small buffers.

Fix: In deserialize, add if (len < 5) return error.InvalidPacket;. In serialize, add if (buf.len < 5 + self.data.len) return error.BufferTooSmall;.