szn

Bug 178 — destroyPane doesn’t remove pty fd from event loop — fd leak / stale events

178. destroyPane doesn’t remove pty fd from event loop — fd leak / stale events

File: src/server/server.zig:370–412 Severity: MEDIUM Status: ✅ FIXED — added self.loop.removeFd(pty.master) call in destroyPane before the pane is removed from the window. Unit test verifies fd is removed from loop after destroyPane.

pub fn destroyPane(self: *Server, pane: *Pane) void {
    // ...
    win.removePane(self.allocator, pane);   // removes from data structures
    // pty.master fd still registered in loop with stale udata!
    // no removeFd(pane.pty.master) called

destroyPane calls win.removePane() which removes the pane from window/layout data structures, but never calls self.loop.removeFd(pane.pty.master). The pty’s master fd remains in the event loop’s poll set with udata pointing to the orphaned pane.

After killSession → session.deinit() → arena.deinit(), the pane’s memory is freed while the fd is still registered. If the fd number is reused by a new allocation, handlePtyEvent could dereference a dangling pointer through udata. The isPaneValid guard prevents this currently (it only does pointer comparison, not dereference), but the fd leak is real.

Impact: File descriptor leak (master pty fd never closed). Under killSession, stale fd in poll set with freed memory pointer.