window.zig + session.zig — Pane double-deinit between Session.deinit and Window.deinitwindow.zig + session.zig — Pane double-deinit between Session.deinit and Window.deinitFile: src/session.zig:54–58, src/window.zig:162–167
Severity: HIGH
Status: ✅ FIXED — added deinited: bool guard to Pane. Pane.deinit() returns early if already deinited. self.pty is set to null after Pty.deinit() for additional safety. Test added for double-deinit safety.
// session.zig deinit:
for (win.panes.items) |p| { p.deinit(); }
// window.zig deinit (via layout.deinit):
// layout.deinitNode calls pane.deinit() AND allocator.destroy(pane)
Session.deinit calls pane.deinit() on every pane. But Window.deinit calls layout.deinit(), which also calls pane.deinit() and allocator.destroy(pane) for each pane. If both are called (which happens in non-arena paths), panes are double-deinited and double-freed.