szn

Bug 88 — defer free on parsed_val.string relies on undocumented dup-in-set contract

88. defer free on parsed_val.string relies on undocumented dup-in-set contract

File: src/cmd/cmd.zig:687–689 Severity: MEDIUM Status: ✅ FIXED — added doc comment on Options.set that it always dupes strings. Unit test verifies caller can free originals after set.

defer {
    if (parsed_val == .string) server.allocator.free(parsed_val.string);
}

Assumes Options.set always dupes strings internally. If Options.set is ever changed to store the pointer directly, this becomes a use-after-free — the option system holds a dangling pointer.