feedPty + handlePtyEvent race: PTY deinited in two different code pathsfeedPty + handlePtyEvent race: PTY deinited in two different code pathsFile: src/window.zig:91–104, src/server/server.zig:234–258
Severity: HIGH
Status: ✅ FIXED — early PTY deinit removed from feedPty and handlePtyEvent; Pty is now solely deinited via Pane.deinit() during pane destruction.
In feedPty():
pub fn feedPty(self: *Pane) Error!void {
const pty = &(self.pty orelse return);
var buf: [4096]u8 = undefined;
const n = pty.readOutput(&buf) catch |err| {
pty.deinit(); // (A) deinit + null
self.pty = null;
return err;
};
Then in handlePtyEvent:
if (has_in) {
pane.feedPty() catch |err| { ... exited = true; };
} else if (has_hup or has_err) { // (B) else-if prevents double entry
if (pane.pty) |*pty| {
pty.deinit(); // guarded by null check, currently safe
}
pane.pty = null;
...
exited = true;
}
if (exited) { self.destroyPane(pane); }
When POLL.IN + POLL.HUP arrive simultaneously, feedPty catches ProcessExited, deinits PTY, sets pane.pty = null. The else if at (B) never fires because has_in was true. Currently safe, but fragile — if someone reorders the if-else chain or moves the exited flag, double-deinit becomes reachable. Also destroyPane → layout.deinitNode → pane.deinit() → p.pty.deinit() is guarded by if (self.pty) |*p|.